fix: Remove warnings when using GCC #389
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize coord_type index{} in begin/end/cbegin/cend to avoid GCC
-Wmaybe-uninitialized with xt::xtensor_fixed (xtensor 0.24).
Fixes warnings like:
xfixed.hpp:334:9: warning: may be used uninitialized [-Wmaybe-uninitialized]
triggered via LevelCellArray::cbegin() constructing const_iterator.
|
Thanks ! It looks like there are still some warnings if you look at the GCC trace built in the CI. Could you also fix these ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue
Warnings when compiling with GCC
How has this been tested?
Compiled demos --> no more warnings when compiling
advection-2dandburgersCode of Conduct
By submitting this PR, you agree to follow our Code of Conduct