Skip to content

Prevent missing the first row of some RecordSets from Spring #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent missing the first row of some RecordSets from Spring #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/net/efabrika/util/DBTablePrinter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,12 @@ public static void printResultSet(ResultSet rs, int maxStringColWidth) {
// Go through each row, get values of each column and adjust
// column widths.
int rowCount = 0;
while (rs.next()) {
if ( ! rs.isAfterLast() ) // No rows are printed if the RS advanced too far already
{
if ( rs.isBeforeFirst() ) // Ensure starting from the first record
{
rs.next();
}

// NOTE: columnIndex for rs.getXXX methods STARTS AT 1 NOT 0
for (int i = 0; i < columnCount; i++) {
Expand Down Expand Up @@ -508,7 +513,7 @@ public static void printResultSet(ResultSet rs, int maxStringColWidth) {
} // END of for loop columnCount
rowCount++;

} // END of while (rs.next)
} while ( rs.next() );

/*
At this point we have gone through meta data, get the
Expand Down