Fix #1623: Decode percent-encoded credentials in URL #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automated tests that reproduce the bug where HTTPie fails to decode percent-encoded characters in URL credentials (username and password). The tests verify that credentials containing special characters like @, =, ?, :, and / should be properly decoded when provided in the URL's userinfo section. Currently all tests fail with 401 UNAUTHORIZED, confirming the bug exists. Related to: httpie#1623
HTTPie now properly decodes percent-encoded characters in the username and password when they are provided in the URL's userinfo section. This allows credentials containing special characters like @, =, and ? to be specified directly in URLs by percent-encoding them. Example that now works: http https://u%40d:1%3d2%3f@httpbin.org/basic-auth/u%40d/1%3d2%3f The fix uses urllib.parse.unquote() to decode the username and password extracted from the URL before using them for authentication. Fixes: httpie#1623
Remove trailing whitespace on blank lines and extra blank lines at end of file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1623
HTTPie now properly decodes percent-encoded characters in the username and password when they are provided in the URL's userinfo section.
This allows credentials containing special characters like
@,=, and?to be specified directly in URLs by percent-encoding them, matching the behavior of other HTTP clients like curl.Changes
httpie/cli/argparser.pyto useurllib.parse.unquote()to decode username and password from URLstest_percent_encoded_credentials_in_url()to verify the fixExample
This now works correctly:
Where
u%40ddecodes tou@dand1%3d2%3fdecodes to1=2?Testing
Checklist