Skip to content

Refactor: Rename _compute_new_headers to compute_merged_headers #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leah866814 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: Rename _compute_new_headers to compute_merged_headers #1676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions httpie/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,16 @@ def post_process_data(self, data: Dict[str, Any]) -> Dict[str, Any]:

return data

def _compute_new_headers(self, request_headers: HTTPHeadersDict) -> HTTPHeadersDict:
"""
Compute merged headers by combining request headers with session headers.

Args:
request_headers: Headers from the current request

Returns:
HTTPHeadersDict with merged headers
"""
def compute_merged_headers(self, request_headers: HTTPHeadersDict) -> HTTPHeadersDict:
new_headers = HTTPHeadersDict()
for name, value in request_headers.copy().items():
if value is None:
Expand Down Expand Up @@ -234,7 +243,7 @@ def update_headers(self, request_headers: HTTPHeadersDict):

"""

new_headers = self._compute_new_headers(request_headers)
new_headers = self.compute_merged_headers(request_headers)
new_keys = new_headers.copy().keys()

# New headers will take priority over the existing ones, and override
Expand Down