Fix JS DOM display issues in BoxWithConstraints and com.huanshankeji.compose.material2.ext.TopAppBarScaffold
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstraints` See the added FIXME for the reason why it doesn't work
…th `DivBox` in `BoxWithConstraints`
….huanshankeji.compose.material2.ext.TopAppBarScaffold`, and `com.huanshankeji.compose.material3.lazy.ext.List` 1. fix the bug that a direct child with `fillMaxSizeStretch` (CSS `stretch`) doesn't work properly in the `content` of `TopAppBarScaffold` that it's sometimes rendered with the height 0 This can be triggered either when used with `BoxWithConstraints` or by changing the window size, and the expected correct behavior can be restored by inspecting the element. The 0-height issue in `BoxWithConstraints` turns out to be caused by this. The root cause for this is that `fillMaxSizeStretch`/`stretch` seems buggy when used directly in a `position: absolute` parent. This may be a bug in the browser engines used. Consider reporting this. 1. try fixing an issue that a scrollable `List` with many items take all the space of a parent `Column` and hide components in the same `Column` before it, but fail
ShreckYe
deleted the
box-with-constraints-react-to-size-changes-js-dom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoxWithConstraintsactually worked already. Its issue was caused bycom.huanshankeji.compose.material2.ext.TopAppBarScaffold.