Skip to content

[ci] xfail more incorrect transformer imports. #12455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2025
+7 −4
Merged

[ci] xfail more incorrect transformer imports. #12455

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9dcfdcb
xfail more incorrect transformer imports.
sayakpaul Oct 9, 2025
905190f
Merge branch 'main' into fix-more-transformer-imports
sayakpaul Oct 14, 2025
8a0d1fa
xfail more.
sayakpaul Oct 14, 2025
439d039
up
sayakpaul Oct 14, 2025
62dff86
up
sayakpaul Oct 14, 2025
76dd4e8
Merge branch 'main' into fix-more-transformer-imports
sayakpaul Oct 17, 2025
f9194f6
up
sayakpaul Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/pipelines/test_pipelines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,7 @@ def test_download_legacy_variants_with_sharded_ckpts_raises_warning(self):
)
assert deprecated_warning_msg in str(cap_logger), "Deprecation warning not found in logs"

@pytest.mark.xfail(condition=is_transformers_version(">", "4.56.2"), reason="Some import error", strict=True)
def test_download_safetensors_only_variant_exists_for_model(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I am missing something, but it appears that this test (and test_download_safetensors_variant_does_not_exist_for_model below) are still marked as failed rather than xfailed in the CI:

FAILED tests/pipelines/test_pipelines.py::DownloadTests::test_download_safetensors_only_variant_exists_for_model
FAILED tests/pipelines/test_pipelines.py::DownloadTests::test_download_safetensors_variant_does_not_exist_for_model

Is this expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is not expected and seeing for the first time. Let me check.

variant = None
use_safetensors = True
Expand Down Expand Up @@ -658,6 +659,7 @@ def test_download_bin_only_variant_exists_for_model(self):
# https://huggingface.co/hf-internal-testing/stable-diffusion-broken-variants/tree/main/unet
assert len(files) == 15, f"We should only download 15 files, not {len(files)}"

@pytest.mark.xfail(condition=is_transformers_version(">", "4.56.2"), reason="Some import error", strict=True)
def test_download_safetensors_variant_does_not_exist_for_model(self):
variant = "no_ema"
use_safetensors = True
Expand Down Expand Up @@ -1890,6 +1892,7 @@ def test_dduf_raises_error_with_connected_pipeline(self):
"DDUF/tiny-flux-dev-pipe-dduf", dduf_file="fluxpipeline.dduf", load_connected_pipeline=True
)

@pytest.mark.xfail(condition=is_transformers_version(">", "4.56.2"), reason="Some import error", strict=True)
def test_wrong_model(self):
tokenizer = CLIPTokenizer.from_pretrained("hf-internal-testing/tiny-random-clip")
with self.assertRaises(ValueError) as error_context:
Expand Down
Loading