Correction to confusing error message on failing name validation.

[goldnode]

"Repo id must use alphanumeric chars or '-', '_', '.', '--' and '..' are forbidden"

did not make sense.

This change will display a clear and correct message for the REGEX check being made. '--' / '..' is a later check.

[Wauplin]

Much better indeed! What do you think of adding the rule about forbidding .. and -- ?

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[goldnode]

Much better indeed! What do you think of adding the rule about forbidding .. and -- ?

I'm not actually sure why '..' and '--' is forbidden to be honest so I didn't want to change the regex, just make the message relevant to the check. The next lines of code (unchanged) already do the '--' and '..' checks though...

if "--" in repo_id or ".." in repo_id:
    raise HFValidationError(f"Cannot have -- or .. in repo_id: '{repo_id}'.")

[Wauplin]

The next lines of code (unchanged) already do the '--' and '..' checks though...

Correct! Then let's keep it as it is now :)

I'm not actually sure why '..' and '--' is forbidden to be honest

Purely technical. Since we use -- as delimiter when creating folder in cache, having a -- in the repo name could be misleading. About the .. is was due to a server-side issue that happened with such a name. It is simply easier to forbid these patterns rather than having to think about them in the logic.