Skip to content

ci: add support for building Win-ARM64 wheels #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

ci: add support for building Win-ARM64 wheels #1869

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c35217
ci: add support for building Win-ARM64 wheels
MugundanMCW Sep 29, 2025
3e3e04e
ci: add support for building Win-ARM64 wheels
MugundanMCW Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,14 @@ jobs:
target: x64
- runner: windows-latest
target: x86
- runner: windows-11-arm
target: aarch64
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.x
architecture: ${{ matrix.platform.target }}
architecture: ${{ matrix.platform.target == 'aarch64' && 'arm64' || matrix.platform.target }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this weird condition, and have 2 target names if it's really needed ? Why isn't the target named aarch64 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Narsil,
The reason for using a separate Python target name for Windows on ARM is that the official Python GitHub Action only supports the architectures x86, x64, and arm64 for Windows [Reference]. Specifying aarch64 for Windows on ARM64 results in an invalid configuration, which causes the CI to fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but then maybe we could have "platform.target" and "platform.architecture" be defined in the matrix, which should make the flow easier to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Narsil thanks for the suggestions, made the relevant changes

- name: Build wheels
uses: PyO3/maturin-action@v1
with:
Expand Down