Skip to content

Add AMD test expectations to DETR model #39539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025

Conversation

ahadnagy
Copy link
Contributor

@ahadnagy ahadnagy commented Jul 20, 2025

What does this PR do?

This model adds the correct test expectations for AMD hardware to the DETR model.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rocketknight1
Copy link
Member

cc @remi-or

Copy link
Contributor

@remi-or remi-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove debug prints and we probably should avoid tensor instanciation inside the dict / use more of the Default expectation

Copy link
Contributor

@remi-or remi-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: could you apply constant formatting across the PR?

(None, None):
     [
         [0.0622, -0.5142, -0.4034],
         [-0.7628, -0.4935, -1.7153],
         [-0.4751, -0.6386, -0.7818],
],

is not consistent w/

(None, None): [[0.5344, 0.1790, 0.9284], [0.4421, 0.0571, 0.0875], [0.6632, 0.6886, 0.1015]],

Otherwise, LGTM. Thanks!

Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: detr

@ahadnagy ahadnagy enabled auto-merge (squash) July 22, 2025 11:57
@ahadnagy ahadnagy merged commit ef99537 into huggingface:main Jul 22, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants