Add Muon optimizer implementation and integration #39541
+177
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well coded. We need muon optimizer for sure. |
SunMarc
reviewed
Jul 21, 2025
There was a problem hiding this comment.
Thanks for the PR @kadirnar ! Definitely intestered in having this in transformers. Can we directly use muon library for this instead of re-coding them ? I saw that there were 4 classes that we might want to have : SingleDeviceMuon, Muon, MuonWithAuxAdam and SingleDeviceMuonWithAuxAdam. Right now in this PR, we deal with the case SingleDeviceMuon. Also, if you can add a couple of tests that we have for all optimizers, that would be great !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39537
cc @muellerzr @SunMarc