-
Notifications
You must be signed in to change notification settings - Fork 30.1k
🌐 [i18n-KO] Translated perf_train_gpu_one.md
to Korean
#39552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
perf_train_gpu_one.md
to Koreanperf_train_gpu_one.md
to Korean
|
수정 완료했습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, feel free to mark as ready once you're ready! 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
번역 고생하셨습니다! 🤗
fix: remove space between heading and GPU anchor Co-authored-by: YONGSANG <71686691+4N3MONE@users.noreply.github.com>
fix: clarify table headers to indicate training speed boost and memory savings Co-authored-by: YONGSANG <71686691+4N3MONE@users.noreply.github.com>
감사합니다! 의견 주신 내용 모두 반영했습니다! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
타이틀 부분 제안드려봅니다 :)
문서 번역하시느라 고생하셨고, 감사합니다
docs/source/ko/_toctree.yml
Outdated
- local: in_translation | ||
title: (번역중) Methods and tools for efficient training on a single GPU | ||
- local: perf_train_gpu_one | ||
title: GPU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: GPU | |
title: 단일 GPU에서 훈련 진행하기 |
로 아래 문서와 통일성 있게 가보면 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
의견 감사합니다 😁
Methods and tools for efficient training on a single GPU 의 경우에는 이전 버전의 제목이라서
현재 버전의 제목인 GPU로 제목을 설정하게 되었습니다! (제목 뿐만 아니라 내용도 많이 바뀐 것 같습니다)

해당 내용 검토 부탁드립니다! 감사합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 그렇군요! 감사합니다 GPU로 그대로 가면될 것 같습니다~~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
매뉴얼 수정도 잘 진행해주셨고 전반적으로 문서가 정말 잘 읽히네요 고생하셨고, 감사합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 번역 감사합니다! 몇 가지 수정 사항 제안드려봅니다 😊
fix: improve readability Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
fix : rephrase explanation of data preloading to improve readability Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
@jungnerd 감사합니다! 수정 완료했습니다 😊 아무래도 데이터 사전 적재라는 표현이 많이 낯설 수 있을 것 같아서, 영문 발음 그대로 해석해야 하나도 많이 고민했었는데, |
Hello @stevhliu 🤗 All reviewer feedback has been addressed, and merge conflicts have been resolved. Thank you very much! 😊 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Translated the
perf_train_gpu_one.md
file of the documentation to Korean.Thank you in advance for your review.
Part of #20179
Before reviewing
[[lowercased-header]]
)Who can review? (Initial)
May you please review this PR?
@4N3MONE, @yijun-lee, @jungnerd , @harheem
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)
@stevhliu May you please review this PR?