Skip to content

🌐 [i18n-KO] Translated perf_train_gpu_one.md to Korean #39552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 29, 2025

Conversation

D15M4S
Copy link
Contributor

@D15M4S D15M4S commented Jul 21, 2025

What does this PR do?

Translated the perf_train_gpu_one.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
@4N3MONE, @yijun-lee, @jungnerd , @harheem

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@D15M4S D15M4S changed the title [i18n-KO] Translated perf_train_gpu_one.md to Korean 🌐 [i18n-KO] Translated perf_train_gpu_one.md to Korean Jul 21, 2025
@harheem
Copy link
Contributor

harheem commented Jul 21, 2025

Translated the <your_file>.md file of the documentation to Korean.
=> PR 본문의 perf_train_gpu_one.md 로 수정 부탁드려요!

@D15M4S
Copy link
Contributor Author

D15M4S commented Jul 22, 2025

Translated the <your_file>.md file of the documentation to Korean. => PR 본문의 perf_train_gpu_one.md 로 수정 부탁드려요!

수정 완료했습니다!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, feel free to mark as ready once you're ready! 🤗

Copy link
Contributor

@4N3MONE 4N3MONE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 고생하셨습니다! 🤗

D15M4S and others added 2 commits July 24, 2025 10:04
fix: remove space between heading and GPU anchor

Co-authored-by: YONGSANG <71686691+4N3MONE@users.noreply.github.com>
fix: clarify table headers to indicate training speed boost and memory savings

Co-authored-by: YONGSANG <71686691+4N3MONE@users.noreply.github.com>
@D15M4S
Copy link
Contributor Author

D15M4S commented Jul 24, 2025

번역 고생하셨습니다! 🤗

감사합니다! 의견 주신 내용 모두 반영했습니다! 😄

Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타이틀 부분 제안드려봅니다 :)
문서 번역하시느라 고생하셨고, 감사합니다 ☺️

- local: in_translation
title: (번역중) Methods and tools for efficient training on a single GPU
- local: perf_train_gpu_one
title: GPU
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: GPU
title: 단일 GPU에서 훈련 진행하기

로 아래 문서와 통일성 있게 가보면 어떨까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의견 감사합니다 😁
Methods and tools for efficient training on a single GPU 의 경우에는 이전 버전의 제목이라서
현재 버전의 제목인 GPU로 제목을 설정하게 되었습니다! (제목 뿐만 아니라 내용도 많이 바뀐 것 같습니다)

image

해당 내용 검토 부탁드립니다! 감사합니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 그렇군요! 감사합니다 GPU로 그대로 가면될 것 같습니다~~~

Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
매뉴얼 수정도 잘 진행해주셨고 전반적으로 문서가 정말 잘 읽히네요 고생하셨고, 감사합니다 ☺️

Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다! 몇 가지 수정 사항 제안드려봅니다 😊

D15M4S and others added 2 commits July 25, 2025 19:53
fix: improve readability

Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
fix : rephrase explanation of data preloading to improve readability

Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
@D15M4S
Copy link
Contributor Author

D15M4S commented Jul 25, 2025

좋은 번역 감사합니다! 몇 가지 수정 사항 제안드려봅니다 😊

@jungnerd 감사합니다! 수정 완료했습니다 😊

아무래도 데이터 사전 적재라는 표현이 많이 낯설 수 있을 것 같아서, 영문 발음 그대로 해석해야 하나도 많이 고민했었는데,
영문 병기라는 답이 있다는 것은 미처 생각 못했습니다! 좋은 답안 제시해주셔서 감사합니다!

@D15M4S D15M4S marked this pull request as ready for review July 28, 2025 13:43
@D15M4S
Copy link
Contributor Author

D15M4S commented Jul 28, 2025

Hello @stevhliu 🤗

All reviewer feedback has been addressed, and merge conflicts have been resolved.
Since the PR has been approved, I would really appreciate it if you could take a final look and merge it when convenient.

Thank you very much! 😊

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 43fe41c into huggingface:main Jul 29, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants