Skip to content

Conversation

ChoHyoungSeo
Copy link

@ChoHyoungSeo ChoHyoungSeo commented Jul 21, 2025

What does this PR do?

Translated the main_classes/deepspeed.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! We can merge once a Korean reader has reviewed as well :)

Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 감사합니다! 일부 문장에 대해서 리뷰해 보았어요.

@harheem
Copy link
Contributor

harheem commented Aug 2, 2025

@ChoHyoungSeo 형서님! PR 감사합니다.
[Resolve conflicts] 버튼을 통해 문서 충돌을 해결해주시면 approved 하겠습니다 🤗

ChoHyoungSeo and others added 2 commits August 8, 2025 22:46
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
@stevhliu
Copy link
Member

Would you mind rebasing to fix the CI tests? I'll also merge this for you once we've ironed out an issue with the doc-builder! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants