Ignore decoder_inputs_embeds when decoder_input_ids are present (fixes #39542) #39566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39542
What does this PR do?
When using a custom seq2seq model together with PEFT/LoRA, both
decoder_input_ids
anddecoder_inputs_embeds
can end up being passed to the underlying decoder. This triggers the internal validation:ValueError: You cannot specify both decoder_input_ids and decoder_inputs_embeds at the same time
This PR adds a small defensive override in
Seq2SeqTrainer.compute_loss
that dropsdecoder_inputs_embeds
whendecoder_input_ids
are also present. This keeps backward compatibility and mirrors the user expectation thatdecoder_input_ids
should take precedence.Implementation details