Cleanup reference to TFBertTokenizer and TFGPT2Tokenizer #42182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Rocketknight1
force-pushed
the
cleanup_tf_reference
branch
8 times, most recently
from
28d6a65 to
60bb2c3
Compare
utils/check_docstrings.py
Outdated
| # Signature is *args/**kwargs | ||
| "TFSequenceSummary", | ||
| "TFBertTokenizer", | ||
| "TFGPT2Tokenizer", |
Member
There was a problem hiding this comment.
remove TF ref for GPT2 as well?
Member
Author
There was a problem hiding this comment.
Woah, I somehow didn't see that. Good spot.
zucchini-nlp
approved these changes
Nov 17, 2025
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Approving in advance, it's only two more lines to delete
Rocketknight1
changed the title
Rocketknight1
force-pushed
the
cleanup_tf_reference
branch
from
af1b1a6 to
df3e20b
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bert, gpt2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reference to
TFBertTokenizerwas left behind after removing TF/JAX support, which caused some issues. This PR removes it!Fixes #42175