Remove test inheritance for EfficientLoftr, rename KeypointMatchingOutput to model specific name #42365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inheritance, remove irrelevant test
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
molbap
approved these changes
Nov 24, 2025
Contributor
molbap
left a comment
molbap
left a comment
There was a problem hiding this comment.
Ok for the renaming. So we remove test inheritance for now? I thought we were ok with that (in tests ONLY of course) at some point. OK either way
vasqu
approved these changes
Nov 24, 2025
Comment on lines
+1357
to
+1359
| loss = None | ||
| return EfficientLoFTRKeypointMatchingOutput( | ||
| loss=loss, |
Contributor
There was a problem hiding this comment.
Do we always have a loss of None? It's a bit weird to me but maybe training here just isn't supported
Member
Author
There was a problem hiding this comment.
Yes just kept if for API consistency, but training isn't supported
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: efficientloftr, lightglue, superglue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove inheritance in efficient loftr tests (following #42327). Also fix source of the issue, KeypointMatchingOutput is different for each keypoint matching model, so rename it to model-specific names.