Skip to content

Conversation

@dhable
Copy link
Contributor

@dhable dhable commented Oct 17, 2025

The alerts code and some of our private source tasks are becoming complex enough for multiple files. In order to keep the code clearer to debug and read, this commit moves the check alerts tasks into a sub-directory for just alert related code.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: d83c0e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 27, 2025 5:53pm

@claude
Copy link

claude bot commented Oct 17, 2025

No critical issues found.

This is a clean refactoring that reorganizes alert-related code into a subdirectory structure. All import paths have been correctly updated, tests moved appropriately, and the changes maintain existing functionality.

Note: There is a pre-existing circular dependency pattern between checkAlerts/index.ts and providers/default.ts, but this existed before this PR and is handled correctly by TypeScript/Node.js module resolution.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

E2E Test Results

All tests passed • 26 passed • 3 skipped • 220s

Status Count
✅ Passed 26
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

The alerts code and some of our private source tasks are becoming complex
enough for multiple files. In order to keep the code clearer to debug and
read, this commit moves the check alerts tasks into a subdirectory for just
alert related code.
@kodiakhq kodiakhq bot merged commit 431a9f0 into main Oct 27, 2025
10 checks passed
@kodiakhq kodiakhq bot deleted the dan/hdx-2622-refactor-tasks branch October 27, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants