chore: Standardize granularities #1551
Open
+89
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 760ee91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code ReviewOverall Assessment: Clean refactoring with good architectural improvements. Found one issue that needs attention: Issues
Positive Changes
|
Contributor
E2E Test Results✅ All tests passed • 59 passed • 4 skipped • 769s
Tests ran across 4 shards in parallel. |
pulpdrew
force-pushed
the
drew/standardize-granularities
branch
from
8f01199 to
1cc78a6
Compare
pulpdrew
force-pushed
the
drew/standardize-granularities
branch
from
a6ab41e to
2038ea6
Compare
pulpdrew
requested review from
a team and
wrn14897
and removed request for
a team
pulpdrew
force-pushed
the
drew/standardize-granularities
branch
from
2038ea6 to
7321b64
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
…#1533) Closes HDX-3067 Closes #1331 Closes #1212 Closes #1468 # Summary This PR makes a number of improvements around the way we handle date ranges and granularities, in an effort to minimize discrepancies between aggregate values queried from original data and aggregate values queried from materialized views. 1. Date ranges for Line and Bar chart queries are now (by default) auto-aligned to the chart's granularity. **This is not limited to materialized view queries.** Since the chart granularity is a multiple of the MV granularity, this ensures that the date range is aligned to the MV granularity as well. This also address a number of related issues that point out 0-values or low-values in the first or last data points. This PR also includes an option to disable this behavior for charts in Chart Explorer or Dashboard Tiles. 2. All materialized view queries and all time chart queries are now end-exclusive, to avoid selecting the entirety of the next "time bucket" from the materialized view when the date range is aligned with the materialized view granularity 3. Materialized views are only used for a query with a granularity if the chart query granularity is a multiple of the MV granularity. Previously, we'd use the MV as long as the chart query granularity was at least as large as the MV granularity, but this could cause unequal distributions of data across time buckets. Nearly all available granularities are multiples of all smaller available granularities - so this should only impact queries with granularity 15 minutes with MVs with granularity 10 minutes. 10m granularity support is being removed in #1551 ## Demo <details> <summary>Show Complete Intervals Option</summary> https://github.com/user-attachments/assets/4b903adb-4edf-4481-93d6-2a0c42589a37 </details>
pulpdrew
force-pushed
the
drew/standardize-granularities
branch
from
7321b64 to
1947e1f
Compare
pulpdrew
force-pushed
the
drew/standardize-granularities
branch
from
1947e1f to
760ee91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HDX-3094
Summary
This PR standardizes available granularities and inferred/auto granularities throughout the app