Fix bug where loading saved search from another page #1563
Merged
+345
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t values instead - also adds tests for the scenario Fixes HDX-3149
brandon-pereira
requested review from
a team and
pulpdrew
and removed request for
a team
🦋 Changeset detectedLatest commit: 7c1c27f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review✅ No critical issues found. The implementation correctly addresses the saved search state management bug. Key improvements:
Minor observations (non-blocking):
|
Contributor
E2E Test Results✅ All tests passed • 59 passed • 4 skipped • 740s
Tests ran across 4 shards in parallel. |
pulpdrew
reviewed
Jan 7, 2026
kodiakhq
bot
deleted the
brandon/search-page-initialization-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where loading a saved search page from another non-search page may result in the default select/order by being used instead of the saved search values.
Attempts to make these types of errors happen less by creating a new
defaultSearchConfigobject which represents the default values to fallback on (currently it was mixing concerns in a few places)also adds tests for the scenario
Fixes HDX-3149