Put source error into the Display impl of Status #2417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's how the error looks before this change:
```
status: 'Some resource has been exhausted', self: "h2 protocol error: http2 error"
```
And here it is after:
```
status: 'Some resource has been exhausted', self: "h2 protocol error: http2 error", source: tonic::transport::Error(Transport, hyper::Error(Http2, Error { kind: GoAway(b"ivan_says_hello", ENHANCE_YOUR_CALM, Remote) }))
```
The latter gives the user a lot more context about the issue.
alexanderrilee
pushed a commit
to alexanderrilee/tonic
that referenced
this pull request
Oct 29, 2025
Here's how the error looks before this change:
```
status: 'Some resource has been exhausted', self: "h2 protocol error: http2 error"
```
And here it is after:
```
status: 'Some resource has been exhausted', self: "h2 protocol error: http2 error", source: tonic::transport::Error(Transport, hyper::Error(Http2, Error { kind: GoAway(b"ivan_says_hello", ENHANCE_YOUR_CALM, Remote) }))
```
The latter gives the user a lot more context about the issue.
Co-authored-by: tottoto <tottotodev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's how the error looks before this change:
And here it is after:
The latter gives the user a lot more context about the issue.