Skip to content

Refine invalid mention message #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

Refine invalid mention message #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/MentionPopoverContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export default function MentionPopoverContent({
<div className="px-3 py-2">
{typeof content === 'string' ? (
<div data-testid="user-not-found">
No user with username <span className="font-bold">{content}</span>{' '}
exists
User <span className="font-bold">{content}</span> does not exist or
does not have access to this group
</div>
) : (
<div className="flex flex-col gap-y-4">
Expand Down
5 changes: 4 additions & 1 deletion src/components/test/MentionPopoverContent-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ describe('MentionPopoverContent', () => {
const userNotFound = wrapper.find('[data-testid="user-not-found"]');

assert.isTrue(userNotFound.exists());
assert.equal('No user with username @invalid exists', userNotFound.text());
assert.equal(
'User @invalid does not exist or does not have access to this group',
userNotFound.text(),
);
assert.isFalse(wrapper.exists('[data-testid="username"]'));
assert.isFalse(wrapper.exists('[data-testid="display-name"]'));
});
Expand Down