Skip to content

Conversation

cruse1977
Copy link

This PR updates the plugin significantly.

  • v0.0.11 for NetBox 4.2.x support
  • Resolves a number of open issues
  • Implements a couple of requested features (Navigation + Optional Site on Number)
  • Removes legacy conditionals and standardises models
  • Standardises compatibility matrix on README
  • Converts to pyproject.toml away from setup.py

Tested against NetBox 4.2.3 (Docker)

@iDebugAll
Copy link
Owner

Hey @cruse1977,

Thank you for the great PR!

I'm currently testing this in my dev environment. A few points I came across already:

  1. Dockerfile needs some minor fixes to build properly:
FROM netboxcommunity/netbox:latest

COPY ./phonebox_plugin /source/phonebox_plugin/phonebox_plugin/
COPY ./pyproject.toml /source/phonebox_plugin/
COPY ./MANIFEST.in /source/phonebox_plugin/
COPY ./README.md /source/phonebox_plugin/
RUN /usr/local/bin/uv pip install --no-cache-dir /source/phonebox_plugin/
  1. Could you make the Site field a multi-choice field? In many organizations, the Number-Site relation can be many-to-many. For example, a number could be received via both a SIP trunk in Site_DC1 and an E1 circuit in Site_DC2 in the same region.

@cruse1977
Copy link
Author

Sure, will do

@jscooksey
Copy link

any chance this will be merged soon?

@wallacj1899
Copy link

I too am wondering when we think this will be merged. Are there issues? How likely is it to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants