Draping Bug #8293
Open
Draping Bug #8293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielzhong-bentley
requested review from
a team,
aruniverse,
bbastings and
ben-polinsky
as code owners
|
Won't reusing a previous projection matrix cause the results to be inaccurate? In the user's recording, the camera angle is not very close to parallel to the drape when the "smearing" occurs. What specifically is unstable or correct about the matrix, and is fixing it an option? |
|
@pmconne After more investigation, I believe the changes in this PR are more of a hack than a proper solution and likely not helpful. However, please check the root cause of the issue in the backlog link below, any feedback would be greatly appreciated. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/iTwin/projects/37/views/26?sliceBy%5Bvalue%5D=danielzhong-bentley&pane=issue&itemId=117082771&issue=iTwin%7Citwin-graphics-backlog%7C698
This PR fixes an issue where the planar texture projection matrix becomes unstable or incorrect (example: for some model, camera angle being nearly parallel to the drape), resulting in rendering artifacts.
Solution:
Created
isProjetionMatrixUnstable()to detect whether the computed projection matrix deviates from a valid and expected format. If the matrix is found to be unstable, the system reuses the last known stable projection matrix to drape.