Skip to content

Conversation

dassaf4
Copy link
Member

@dassaf4 dassaf4 commented Oct 9, 2025

This is a generalization more suitable to Arc3d. When the instance is a circular fillet, the default inputs yield the arc's PI.

@dassaf4 dassaf4 changed the title Add PI point construction to Arc3d Add PI construction to Arc3d Oct 9, 2025
@dassaf4 dassaf4 linked an issue Oct 9, 2025 that may be closed by this pull request
@dassaf4
Copy link
Member Author

dassaf4 commented Oct 9, 2025

@saeeedtorabi Here's an untested implementation. Please generate some tests and verify. One way to verify for circular arc inputs is to call the line string fillet method you recently worked on and try to recover the original line string vertices removed by each fillet arc. Some edge cases to consider:

  • f0 === f1
  • 0/pi/2pi sweeps (or within Geometry.smallAngleRadians)
  • non-circular arc
  • non-xy arc

@dassaf4 dassaf4 marked this pull request as ready for review October 10, 2025 21:22
@dassaf4 dassaf4 enabled auto-merge (squash) October 10, 2025 21:22
@dassaf4 dassaf4 merged commit cd4c739 into master Oct 15, 2025
15 checks passed
@dassaf4 dassaf4 deleted the da4/arc3d-pi-point branch October 15, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a property on Arc3d for the PI

2 participants