Update lru.py #26
Open
Update lru.py #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The cache caches values by reference and not by value. I recommend caching by value (aka cache deep copies instead of a reference to the object) to avoid very weird behavior. I've been a developer for a long time, and I've rarely facepalmed because of an issue I just couldn't get like this :). |
doubledare704
added a commit
to doubledare704/async-cache
that referenced
this pull request
Apr 21, 2025
doubledare704
added a commit
to doubledare704/async-cache
that referenced
this pull request
Apr 21, 2025
|
Seems like this project is in passive state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.