-
-
Notifications
You must be signed in to change notification settings - Fork 84
Implement basic functionality for virtualization #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
| ...(rowStyle ? rowStyle(record, virtualRow.index) : {}), | ||
| height: `${virtualRow.size}px`, | ||
|
|
||
| // transform: `translateY(${virtualRow.start}px)`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably remove the commented code that was left in.
|
You also want to target your PR against the next branch. This is outlined here: |
|
Excited for this! |
|
Will this PR be merge? I'm having performance issues in my project and if it will not be merge, I will search for manual solutions. |
|
This is a great feature and it would be nice if somebody can put some effort in this to see if it is already mergeable and/or investigate what still has to be done. |
|
it's a useful thing. I tried to attach it through a wrapper, but it seems that I don't have enough control to implement it in an external environment on my own. I don't want to spend a lot of time on it. I would like to have a simple implementation or at least documentation on how to implement it. |
|
This would be amazing to see, @icflorescu any chance this will get merged? |
|
Started using this project and really liked it. |
Hi @icflorescu !
Recently the need for a virtualization increased on my side. I tried to implement the virtualization with TanStack's virtual table example.
So far the base implementation (measuring elements, overscanning, remounting DOM elements, ...) works.
What is left:
I hope you or someone else can support with the relative visual todos so that we can all benefit from the feature.