Audio pipeline dependencies are reduced, bug fixed, room acoustics made more tunable and demo improved #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e jupyter notebook.
…on pipeline in the jupyter notebook
- Clean pavel fuction header. - Add datasets as a dependency
|
Bug found: Do not merge |
…ndering only of the step 3 - Fix center of the room position x and y axis - Add method to change the position of the microphone after the initialization of the room object
… with anchors at the correct place. - Fix the biggest problem of the weird convertion from Position3D to List before creating the pyroom. - Add margin for 3D when placing mics, objects and speakers - Add a new tutorial (N°15) to generate a lot of room and their following audio accoustics without re-computing steps 1 and 2 - Test all previous tutorials to see if we have any regression (none as been seen)
- The object is out of the room boudaries (even when hardcoded in the code somewhere before the rendering) - Handle the case where the audio sources are far away from the microphone.
- Remove tutorial to_audio by including its content into tutorials 8 and 9
- Swap tutorials 13 and 14
- Fix some unwanted cases for the Room class - Add unit tests for the audio package
…p the missing required ones with predefined values in the body of the fuction. It's easier to read like this. - Make BaseTTS extends ABC in order to be sure that it's an abstract class that cannot be instantiated. - Create unit tests for the audio module semi-automatically using Gemini 2.5 Pro (thinking mode).
- Show the dscaper error when the transfert of the files failed - Remove installation of scaper and dscaper from the tutorials 9, 10 and 13
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 46.72% 55.43% +8.71%
==========================================
Files 20 34 +14
Lines 4152 5931 +1779
==========================================
+ Hits 1940 3288 +1348
- Misses 2212 2643 +431
🚀 New features to boost your workflow:
|
…inference - Add dsiplay function in AudioDialog - Make __str__ for RecordingDevice - Add some comments to the tutorials - Run all tutorials back - Add local impulse response database in the the tutorial 16 - Add tests data for IR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.