Add not LTE implies GT, and LTE implies maximum. #4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadsalim
reviewed
Apr 27, 2018
| isLTE (S k) (S j) with (isLTE k j) | ||
| isLTE (S k) (S j) | (Yes prf) = Yes (LTESucc prf) | ||
| isLTE (S k) (S j) | (No contra) = No (contra . fromLteSucc) | ||
| isLTE (S k) (S j) = case isLTE k j of |
There was a problem hiding this comment.
Is there any reason for the change here? 😄
ahmadsalim
reviewed
Apr 27, 2018
| sucMinR Z = Refl | ||
| sucMinR (S l) = cong (sucMinR l) | ||
|
|
||
| ||| If one number is biggre than another, you know what the maximum is. |
There was a problem hiding this comment.
There is a small typo biggre -> bigger
ahmadsalim
reviewed
Apr 27, 2018
| sucMinR (S l) = cong (sucMinR l) | ||
|
|
||
| ||| If one number is biggre than another, you know what the maximum is. | ||
| total lteImpliesMax : i `LTE` j -> maximum i j = j |
There was a problem hiding this comment.
Maybe this should be added to contrib instead of prelude?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the existing
notLTImpliesGTE- wasn't sure if there was a way I could use it (besides cribbing from its implementation), so I just implementednotLTEImpliesGT, so I could apply it to the disproof returned byisLTE, as in:As for
lteImpliesMax, I figure knowing which number is greater should enable you to say something about the maximum, or at least they should be related, somehow. I needed it for something I was working on.