Fix notification target_roles enum mismatch

[pixelsama]

Important

1. Read CONTRIBUTING.md
2. Ensure issue exists and you're assigned
3. Link correctly: Fixes #<issue number>

What & Why

What: Align notification migrations to use user_role[] for target_roles and keep RLS/aggregation functions consistent with the enum.
Why: Migration 20250822140000_create_notifications_system.sql fails because the policy compares text[] with user_role[] (no operator). Matching the enum fixes SQLSTATE 42883 and lets db push succeed.

Fixes #307

Pre-PR Checklist

Run these:

• pnpm type-check
• pnpm format:check
• pnpm lint
• pnpm build
• pnpm i18n:check (if applicable)

Type

• 🐛 Bug fix
• ✨ Feature
• 💥 Breaking change
• 📚 Docs
• ♻️ Refactor
• ⚡ Performance

Screenshots (if UI changes)

N/A

[vercel]

@pixelsama is attempting to deploy a commit to the zhang's projects Team on Vercel.

A member of the Team first needs to authorize it.

[gemini-code-assist]

Summary of Changes

Hello @pixelsama, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical database migration failure by correcting a type mismatch in the target_roles column of the notifications table. By aligning the column type with the user_role[] enum, it ensures that RLS policies and notification aggregation functions operate correctly, thereby enabling the successful deployment and proper functioning of the notification system's targeting and unread count features.

Highlights

• Enum Type Correction: The target_roles column in the public.notifications table was updated from text[] to user_role[] to resolve a type mismatch error that was preventing database migrations from succeeding.
• RLS and Function Consistency: Row-Level Security policies and existing aggregation functions (get_user_unread_count) were adjusted to correctly interact with the user_role[] enum type, ensuring proper notification targeting logic.
• New Optimization Function: A new migration introduces get_user_unread_count_by_category, a function designed to efficiently provide unread notification counts grouped by category, further enhancing the notification system's performance and also correctly using the user_role[] type.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly fixes the target_roles enum mismatch, which resolves the database migration failure. The new migrations establish a comprehensive notification system. However, I've identified a critical security vulnerability and several high-severity performance issues that should be addressed.

The main concerns are:

• A SECURITY DEFINER function lacks proper authorization checks, allowing users to perform actions on behalf of others.
• Several RLS policies and functions use subqueries that can execute for each row, leading to poor performance on large tables. I've suggested creating and using helper functions to mitigate this.
• There are also opportunities to improve the SQL style for better readability and performance.

Please review the detailed comments for specific suggestions.