-
Notifications
You must be signed in to change notification settings - Fork 9
fix(deps): upgrade React and Next.js for security vulnerabilities #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upgrade to patched versions to address: - CVE-2025-55184: Denial of Service (High, CVSS 7.5) - CVE-2025-67779: Additional DoS case (High, CVSS 7.5) - CVE-2025-55183: Source Code Exposure (Medium, CVSS 5.3) Package updates: - react: 19.1.1 → 19.1.4 - react-dom: 19.1.1 → 19.1.4 - next: 15.4.7 → 15.4.10 Previous patches (19.0.2, 19.1.3, 19.2.2) were incomplete. These new versions provide complete mitigation. References: - react.dev/blog/2025/12/11/denial-of-service-and-source-code - nextjs.org/blog/security-update-2025-12-11
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @lyzno1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a crucial security update, upgrading key frontend dependencies to address recently discovered vulnerabilities. The changes ensure the application is protected against potential Denial of Service attacks and source code exposure, enhancing the overall stability and security posture of the project. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly upgrades react, react-dom, and next to their patched versions to address the mentioned security vulnerabilities. The changes in package.json and the corresponding updates in pnpm-lock.yaml are appropriate and look good. As a follow-up, I'd suggest also updating the eslint-config-next dev dependency to 15.4.10 to match the new next version. This would ensure your linting rules are aligned with the framework version, preventing potential inconsistencies. Since this was outside the diff, I'm mentioning it here for your consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| optionalDependencies: | ||
| '@next/swc-darwin-arm64': 15.4.7 | ||
| '@next/swc-darwin-x64': 15.4.7 | ||
| '@next/swc-linux-arm64-gnu': 15.4.7 | ||
| '@next/swc-linux-arm64-musl': 15.4.7 | ||
| '@next/swc-linux-x64-gnu': 15.4.7 | ||
| '@next/swc-linux-x64-musl': 15.4.7 | ||
| '@next/swc-win32-arm64-msvc': 15.4.7 | ||
| '@next/swc-win32-x64-msvc': 15.4.7 | ||
| '@next/swc-darwin-arm64': 15.4.8 | ||
| '@next/swc-darwin-x64': 15.4.8 | ||
| '@next/swc-linux-arm64-gnu': 15.4.8 | ||
| '@next/swc-linux-arm64-musl': 15.4.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align Next SWC binaries with 15.4.10 upgrade
next is bumped to 15.4.10, but the lock still pins all optional @next/swc-* binaries to 15.4.8. Next releases expect their compiler binaries at the same patch level; leaving the lock at 15.4.8 means installs will fetch the older compiler, so the intended security fix in the 15.4.10 toolchain is never applied and the runtime can load a mismatched SWC binary. Please regenerate the lock so the @next/swc-* entries match 15.4.10.
Useful? React with 👍 / 👎.
Upgrade to patched versions to address:
Package updates:
Previous patches (19.0.2, 19.1.3, 19.2.2) were incomplete.
These new versions provide complete mitigation.
References: