Skip to content

chore(lts): merge Binarytales/heroku-nodejs #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: lts
Choose a base branch
from
Open

chore(lts): merge Binarytales/heroku-nodejs #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b77de0
Merge pull request #2 from geminiyellow/lts-4-4-3
Binarytales Apr 20, 2016
f4d1403
Node LTS 4.4.6 Argon
Binarytales Jun 28, 2016
70c5716
Node LTS 4.4.6 Argon
Binarytales Jun 28, 2016
ca81a26
docs(readme): `FROM FROM`
geminiyellow May 13, 2016
a38462d
chore(lts): Update to Node.js v4.4.7. Fixes
geminiyellow Jul 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
FROM heroku/cedar:14

# Set Node Version
ENV NODE_ENGINE 4.4.3
ENV NODE_ENGINE 4.4.7

# Set the PATH for Node (inc npm) and any installed runnables
ENV PATH /app/heroku/node/bin/:/app/user/node_modules/.bin:$PATH
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ This hasn't happened yet and so I'm not totally sure exactly which builds get re
The Dockerfile in your project should look something like this for basic usage

```
FROM FROM binarytales/heroku-nodejs:5.6.0
FROM binarytales/heroku-nodejs:5.6.0

ADD package.json /app/user/
RUN /app/heroku/node/bin/npm install
Expand Down