Skip to content

Conversation

@SimonWoidig
Copy link
Contributor

Fixes #200

@SimonWoidig SimonWoidig force-pushed the container-security-context branch from 3e8f186 to f78b754 Compare June 9, 2025 13:26
@SimonWoidig
Copy link
Contributor Author

I don't want to rush anyone, but the PR is ready I think and there are not that many changes. Would appreciate if anyone looked at it.
Thank you!

@C4tWithShell
Copy link

@DarthSim

@gzigzigzeo
Copy link
Collaborator

Awesome. Could you please mention containerSecurityContext field in the README? Besides that, looks good for me. @SimonWoidig

@SimonWoidig
Copy link
Contributor Author

Awesome. Could you please mention containerSecurityContext field in the README? Besides that, looks good for me. @SimonWoidig

Will do!

@SimonWoidig
Copy link
Contributor Author

Sorry for the noise, but I've updated the readme. The description for the pod securityContext didn't make much sense to me but I didn't change it. For the containerSecurityContext I have added a bit different description with a link to the K8s docs.
If you want, I can also change the securityContext to be more similar or vice versa (the containerSecurityContext).

@gzigzigzeo
Copy link
Collaborator

Thank you. We have #198, which addresses the same issue. It renames securityContext to podSecurityContext which is much more logical - but breaks backward compatibility at the same time. I am going to merge your PR, and then will add podSecurityContext as an alias for securityContext (or vice versa) in the separate PR.

@gzigzigzeo gzigzigzeo merged commit 8b2a661 into imgproxy:master Sep 25, 2025
1 check passed
@SimonWoidig SimonWoidig deleted the container-security-context branch September 25, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing SecurityContext for container

3 participants