Skip to content

Optimize isFrozen utility #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Optimize isFrozen utility #1180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f399907
Optimize `isFrozen` utility to handle primitives and null/undefined e…
riqts Sep 20, 2025
75541cb
Undo linting change
riqts Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,12 @@ export function freeze<T>(obj: T, deep?: boolean): T
export function freeze<T>(obj: any, deep: boolean = false): T {
if (isFrozen(obj) || isDraft(obj) || !isDraftable(obj)) return obj
if (getArchtype(obj) > 1 /* Map or Set */) {
Object.defineProperties(obj, {
set: {value: dontMutateFrozenCollections as any},
add: {value: dontMutateFrozenCollections as any},
clear: {value: dontMutateFrozenCollections as any},
delete: {value: dontMutateFrozenCollections as any}
})
Object.defineProperties(obj, {
set: {value: dontMutateFrozenCollections as any},
add: {value: dontMutateFrozenCollections as any},
clear: {value: dontMutateFrozenCollections as any},
delete: {value: dontMutateFrozenCollections as any}
})
}
Object.freeze(obj)
if (deep)
Expand All @@ -218,5 +218,8 @@ function dontMutateFrozenCollections() {
}

export function isFrozen(obj: any): boolean {
// Fast path: primitives and null/undefined are always "frozen"
if (obj === null || typeof obj !== "object") return true

return Object.isFrozen(obj)
}