refactor(files): update interface #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors file-related interfaces by splitting the generic FileInfo interface into two more specific, context-aware interfaces: UploadFileInfo and DownloadFileInfo. This improves type safety and code clarity by distinguishing between upload and download operations.
- Split
FileInfointoUploadFileInfo(withid,post_url,post_fields) andDownloadFileInfo(withurl) - Updated all imports and usages across affected files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/interface.ts | Replaced FileInfo interface with two new interfaces: UploadFileInfo and DownloadFileInfo |
| src/lib/upload-files.ts | Updated import and variable type from FileInfo to UploadFileInfo |
| src/lib/download-file.ts | Updated import and variable type from FileInfo to DownloadFileInfo |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.