Skip to content

Fixed BIN check for new mastercard range (2221-2720) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed BIN check for new mastercard range (2221-2720) #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CreditCard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class CreditCard
),
'mastercard' => array(
'type' => 'mastercard',
'pattern' => '/^(5[0-5]|2[2-7])/',
'pattern' => '/^(5[0-5]|2(2(2[1-9]|[3-9])|[3-6]|7(0|1|20)))/',
'length' => array(16),
'cvcLength' => array(3),
'luhn' => true,
Expand Down
37 changes: 37 additions & 0 deletions tests/Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,28 @@ class Test extends PHPUnit_Framework_TestCase
'5555555555554444',
'5454545454545454',
'2221000002222221',
'2222000000000008',
'2223000000000007',
'2224000000000006',
'2225000000000005',
'2226000000000004',
'2227000000000003',
'2228000000000002',
'2229000000000001',
'2230000000000008',
'2240000000000006',
'2250000000000003',
'2260000000000001',
'2270000000000009',
'2280000000000007',
'2290000000000005',
'2300000000000003',
'2400000000000002',
'2500000000000001',
'2600000000000000',
'2700000000000009',
'2710000000000007',
'2720999999999996',
),
'amex' => array(
'378282246310005',
Expand Down Expand Up @@ -67,6 +89,14 @@ class Test extends PHPUnit_Framework_TestCase
),
);

protected $invalidCards = array(
'mastercard' => array(
'2220000000000000',
'2721000000000004',
),
);


public function testCardsTypes()
{
foreach ($this->validCards as $type => $numbers) {
Expand All @@ -77,6 +107,13 @@ public function testCardsTypes()
$this->assertEquals($type, $result['type'], 'Invalid type. Number: ' . $number . ', Expected: ' . $type . ', Actual: ' . $result['type']);
}
}

foreach ($this->invalidCards as $type => $numbers) {
foreach ($numbers as $number) {
$result = CreditCard::validCreditCard($number);
$this->assertNotEquals($type, $result['type'], 'Invalid type. Number: ' . $number . ', Should not be: ' . $type . ', Actual: ' . $result['type']);
}
}
}

public function testNumbers()
Expand Down