Use invokelatest after eval to adjust to upcoming julia change #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1.12, we're cleaning up when implicit world age increments happen at toplevel. Because these test `eval` an expression and immediately call it, an `invokelatest` will likely be required (as it would be right now in local scope). See JuliaLang/julia#56509
|
Thanks for this, I'll merge it once all tests pass. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 35 35
Lines 6759 6759
=======================================
Hits 6738 6738
Misses 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pulsipher
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.12, we're cleaning up when implicit world age increments happen at toplevel. Because these test
evalan expression and immediately call it, aninvokelatestwill likely be required (as it would be right now in local scope). See JuliaLang/julia#56509.