-
Notifications
You must be signed in to change notification settings - Fork 320
Add Windows environment variable instructions for INFLUXDB3_AUTH_TOKEN #6325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
429eea9
Initial plan
Copilot 182f346
feat: add Windows environment variable instructions for INFLUXDB3_AUT…
Copilot 0ea9ca8
refactor: update to new code-placeholders syntax
Copilot fda0246
Merge branch 'master' into copilot/fix-6290
jstirnaman 8f00389
Merge branch 'master' into copilot/fix-6290
jstirnaman e561588
Merge branch 'master' into copilot/fix-6290
jstirnaman a95272f
Merge branch 'master' into copilot/fix-6290
jstirnaman 23bce80
Separate env var and CLI option into distinct sections instead of nes…
Copilot f6fe430
Clarify that both auth methods are for CLI commands with parallel hea…
Copilot d89f33e
Merge branch 'master' into copilot/fix-6290
jstirnaman 874eb22
fix(3ent/core): Set token env var in Windows, clean up structure
jstirnaman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tabs are now (incorrectly) nested. Separate into env var usage and CLI option usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The nested tabs structure has been removed. The documentation now uses two separate sequential sections instead:
This matches the pattern used in the cloud-dedicated docs and provides better accessibility.
Commit: 23bce80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Both apply to CLI commands; you can't use environment variables with anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the headings to clarify that both methods are for CLI commands. The headings are now parallel and clearer:
--tokenoptionBoth are presented as methods to provide your token for
influxdb3CLI commands, as stated in the introductory text.Commit: f6fe430