Skip to content

Conversation

@rahul-infra
Copy link
Contributor

BREAKING CHANGE: Kong module now requires explicit provider aliases for cross-account DNS records.

rahul-infra and others added 2 commits December 4, 2025 15:12
BREAKING CHANGE: Kong module  now requires explicit provider aliases for cross-account DNS records.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Release Preview

Version: v3.0.0
Release Type: major
Status: Release will be published when merged to main


Release Notes

3.0.0 (v2.3.0...v3.0.0) (2025-12-05)

* feat!: Add multi account support for dns and kong modules (e0152b0 (https://github.com/infraspecdev/terraform-aws-kong/commit/e0152b0963b953cc87efff028b02987c6ec88898))

BREAKING CHANGES

* Kong module  now requires explicit provider aliases for cross-account DNS records.

This preview is generated by semantic-release dry-run mode

@rahul-infra rahul-infra changed the title feat!: Add multi account support for dns and kong modules feat!: add multi account support for dns and kong modules. Dec 4, 2025
@rahul-infra rahul-infra changed the title feat!: add multi account support for dns and kong modules. feat!: Add multi account support for dns and kong modules. Dec 4, 2025
@rahul-infra rahul-infra changed the title feat!: Add multi account support for dns and kong modules. FEAT!: Add multi account support for dns and kong modules. Dec 4, 2025
@rahul-infra rahul-infra changed the title FEAT!: Add multi account support for dns and kong modules. FEAT!: add multi account support for dns and kong modules. Dec 4, 2025
@rahul-infra rahul-infra changed the title FEAT!: add multi account support for dns and kong modules. FEAT!: Add multi account support for dns and kong modules Dec 4, 2025
@rahul-infra rahul-infra changed the title FEAT!: Add multi account support for dns and kong modules FEAT!: Add multi account support for dns and kong modules. Dec 4, 2025
@rahul-infra rahul-infra changed the title FEAT!: Add multi account support for dns and kong modules. feat: Add multi account support for dns and kong modules. Dec 4, 2025
@rahul-infra rahul-infra changed the title feat: Add multi account support for dns and kong modules. feat!: Add multi account support for dns and kong modules Dec 4, 2025
@rahul-infra rahul-infra changed the title feat!: Add multi account support for dns and kong modules FEAT!: Add multi account support for dns and kong modules Dec 4, 2025
@rahul-infra rahul-infra changed the title FEAT!: Add multi account support for dns and kong modules feat!: Add multi account support for dns and kong modules Dec 5, 2025
@rahul-infra
Copy link
Contributor Author

In this module the permissions were added explicitly.
So by removing permissions github automatically includes the permissions needed for common PR workflows like validation checks.Due to this issue it never passed the PR-title check action in aws-kong repository.This was not the issue due to Pr-title.yaml.
So we have 2 options:

  1. remove permissions that we have defined in terraform.yaml (where only the kong repo have the permissions set no other repo has permissions added in the yaml file)
  2. Add explicitly permissions that are needed for the github actions to perform.(In our case statuses: write).

we use this action amannn/action-semantic-pull-request@v6.1.1 in our pr title check. so In that action they are triggering an API which is for repo permissions for commit statuses in this file: https://github.com/amannn/action-semantic-pull-request/blob/main/src/index.js. line number 150 so In the github workflows docs it was mentioned that to trigger the API it should have statuses : write permission which was in this repo: https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28#repository-permissions-for-commit-statuses
So, we need to add statuses write in our permissions.

@rahul-infra rahul-infra merged commit 2e78792 into main Dec 8, 2025
31 of 33 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants