Skip to content

Conversation

@stevenj
Copy link
Collaborator

@stevenj stevenj commented Dec 17, 2024

Description

Creates a new crate to hold self-contained Cardano blockchain types.
This allows us to break an emerging circular dependency with the RBAC crate logic.

Related Issue(s)

Arose from: input-output-hk/catalyst-voices#1366
#108

Breaking Changes

The types are based on types in cardano chain follower, but not 100% identical in order to make them more generalized.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stevenj stevenj self-assigned this Dec 17, 2024
@stevenj stevenj added the review me PR is ready for review label Dec 17, 2024
bkioshn and others added 5 commits December 17, 2024 17:42
Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
…ake2bHash

Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
bkioshn and others added 7 commits December 17, 2024 23:40
Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Test Report | ${\color{lightgreen}Pass: 248/248}$ | ${\color{red}Fail: 0/248}$ |

Signed-off-by: bkioshn <bkioshn@gmail.com>
@stevenj stevenj enabled auto-merge (squash) December 18, 2024 09:55
@stevenj stevenj requested a review from bkioshn December 18, 2024 09:55
bkioshn
bkioshn previously approved these changes Dec 18, 2024
Signed-off-by: bkioshn <bkioshn@gmail.com>
@stevenj stevenj disabled auto-merge December 18, 2024 15:38
stevenj and others added 2 commits December 19, 2024 11:45
Co-authored-by: Stanislav Tkach <stanislav.tkach@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
bkioshn
bkioshn previously approved these changes Jan 3, 2025
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 8df0b1c into main Jan 3, 2025
16 checks passed
@stevenj stevenj deleted the feat/cardano-blockchain-types branch January 3, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants