Skip to content

Conversation

@apskhem
Copy link
Collaborator

@apskhem apskhem commented Aug 21, 2025

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

Closes #488
Closes #489

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Aug 21, 2025
@apskhem apskhem added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Aug 21, 2025
@apskhem apskhem linked an issue Aug 21, 2025 that may be closed by this pull request
@apskhem apskhem added this to Catalyst Aug 21, 2025
@apskhem apskhem added the draft Draft label Aug 21, 2025
@apskhem apskhem marked this pull request as draft August 21, 2025 12:49
@apskhem apskhem moved this from New to 🏗 In progress in Catalyst Aug 21, 2025
@apskhem apskhem changed the title refactor(rust/signed-doc): Move validate_id_and_ver as separate IdRule and VerRule refactor(rust/signed-doc): Move validate_id_and_ver as separate rules IdRule and VerRule Aug 21, 2025
@apskhem apskhem moved this from 🏗 In progress to 👀 In review in Catalyst Aug 22, 2025
@apskhem apskhem requested a review from Mr-Leshiy August 22, 2025 15:18
@apskhem apskhem added review me PR is ready for review do not merge yet PR is not ready to be merged yet and removed draft Draft labels Aug 22, 2025
@apskhem apskhem marked this pull request as ready for review August 22, 2025 15:18
@apskhem apskhem removed the do not merge yet PR is not ready to be merged yet label Aug 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Test Report | ${\color{lightgreen}Pass: 423/423}$ | ${\color{red}Fail: 0/423}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nathanbogale nathanbogale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit b35db7c into main Aug 28, 2025
25 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/id_and_ver_rule branch August 28, 2025 12:25
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

IdRule validation rule VerRule validation rule

4 participants