Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Sep 1, 2025

Description

  • Added multiple: bool to the RefRule structure definition.
  • Updated doc_refs_check validation function, with the corresponding check.
  • Updated ContetnRule::Templated, ReplyRule and ParametersRule by always setting multiple to false.

Related Issue(s)

Closes #499

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Sep 1, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Sep 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Test Report | ${\color{lightgreen}Pass: 427/427}$ | ${\color{red}Fail: 0/427}$ |

saibatizoku
saibatizoku previously approved these changes Sep 1, 2025
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Joaquín Rosales <joaquin.rosales@iohk.io>
Co-authored-by: Joaquín Rosales <joaquin.rosales@iohk.io>
@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) September 2, 2025 06:23
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 57f314c into main Sep 2, 2025
25 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/multiple-ref branch September 2, 2025 07:01
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Missing multiple option for document reference validation

4 participants