-
Notifications
You must be signed in to change notification settings - Fork 0
feat(rust/signed-doc): Catalyst Signed Documents validation initialisation fully during the runtime #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ Test Report | |
saibatizoku
previously approved these changes
Sep 9, 2025
Contributor
saibatizoku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d874b5e to
3b5b47a
Compare
catalyst-signed-doc-spec
apskhem
reviewed
Sep 10, 2025
apskhem
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Its a refactoring from get ridding of macro code generation for the instantiation of the validation rules and moved such implementation as a plain Rust functions.
The main reason, that not all of the part is possible to instantiate during the compile time (e.g. JSON schema instance) and the only way how they could be instantiated its only the runtime, so it would become a mix of some things are evaluated during compile time, but some stuff evaluated during runtime still.
Which sounds we are overcomplicating things without no gain
Related Issue(s)
Part of https://github.com/input-output-hk/catalyst-internal-docs/issues/266
Closes #510
Description of Changes
catalyst-signed-doc-speccrate, which contain a definition of thesigned_doc.jsontypes.ContentEncodingRuleinitialisation.catalyst-signed-doccrate from thecatalyst-signed-doc-macrocatalyst-signed-doc-macrocrate.Please confirm the following checks