Skip to content

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Sep 17, 2025

Description

Modifying SignatureKidRule::new method, by including Admin roles into the allowed_roles set.

Related Issue(s)

Part of https://github.com/input-output-hk/catalyst-internal-docs/issues/266

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Sep 17, 2025
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Sep 17, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Sep 17, 2025
@Mr-Leshiy Mr-Leshiy force-pushed the feat/allow-admin-roles branch from 57f3053 to 8589577 Compare September 17, 2025 08:39
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Test Report | ${\color{lightgreen}Pass: 453/453}$ | ${\color{red}Fail: 0/453}$ |

Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit eb975b1 into main Sep 19, 2025
25 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/allow-admin-roles branch September 19, 2025 05:58
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants