Skip to content

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Sep 17, 2025

Description

Closes #551

Description of Changes

  • Defines DocumentOwnershipRule with allow_collaborators: bool
  • Adds unit tests.
  • Fixes clippy lints.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku self-assigned this Sep 17, 2025
@saibatizoku saibatizoku added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Sep 17, 2025
@saibatizoku saibatizoku force-pushed the feat/document-ownership-validation-rule branch from 5b28520 to b6b536c Compare September 18, 2025 16:28
@saibatizoku saibatizoku moved this from New to 🏗 In progress in Catalyst Sep 18, 2025
@saibatizoku saibatizoku force-pushed the feat/document-ownership-validation-rule branch 2 times, most recently from 392dde8 to 4b4d365 Compare September 19, 2025 17:05
Copy link
Contributor

github-actions bot commented Sep 19, 2025

Test Report | ${\color{lightgreen}Pass: 475/475}$ | ${\color{red}Fail: 0/475}$ |

@saibatizoku saibatizoku moved this from 🏗 In progress to 👀 In review in Catalyst Sep 19, 2025
@saibatizoku saibatizoku added the review me PR is ready for review label Sep 19, 2025
@saibatizoku saibatizoku force-pushed the feat/document-ownership-validation-rule branch from d49c96a to 42756fb Compare September 23, 2025 03:38
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Sep 23, 2025
@saibatizoku saibatizoku force-pushed the feat/document-ownership-validation-rule branch from 42756fb to df0b930 Compare September 24, 2025 04:06
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku moved this from 🔖 Ready to 👀 In review in Catalyst Sep 24, 2025
@saibatizoku saibatizoku merged commit 03fe144 into main Sep 24, 2025
44 of 45 checks passed
@saibatizoku saibatizoku deleted the feat/document-ownership-validation-rule branch September 24, 2025 13:05
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Correct OriginalAuthorRule implementation

2 participants