Skip to content

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Sep 19, 2025

Description

  • Added a new field to the signed doc metadata chain
  • Added and refactored serde to DocumentRef and DocumentLocator

Related Issue(s)

Closes #538

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Sep 19, 2025
@apskhem apskhem added this to Catalyst Sep 19, 2025
@apskhem apskhem added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Sep 19, 2025
@apskhem apskhem linked an issue Sep 19, 2025 that may be closed by this pull request
@apskhem apskhem added the draft Draft label Sep 19, 2025
@apskhem apskhem moved this from New to 🏗 In progress in Catalyst Sep 19, 2025
@apskhem apskhem marked this pull request as draft September 19, 2025 14:04
@apskhem apskhem added review me PR is ready for review and removed draft Draft labels Sep 23, 2025
@apskhem apskhem moved this from 🏗 In progress to 👀 In review in Catalyst Sep 23, 2025
@apskhem apskhem marked this pull request as ready for review September 23, 2025 14:50
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Test Report | ${\color{lightgreen}Pass: 468/468}$ | ${\color{red}Fail: 0/468}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one comment LGTM

@apskhem apskhem requested a review from Mr-Leshiy September 24, 2025 06:07
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apskhem apskhem merged commit 6b093b0 into main Sep 24, 2025
25 checks passed
@apskhem apskhem deleted the feat/chain-metadata-field branch September 24, 2025 06:24
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

New chain metadata field

2 participants