Skip to content

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Sep 23, 2025

Description

Added missing integration tests for a bunch of document types:

  • Brand Parameters Form Template
  • Brand Parameters
  • Campaign Parameters Form Template
  • Campaign Parameters
  • Category Parameters Form Template
  • Category Parameters
  • Proposal Comment Form Template
  • Proposal Form Template

Related Issue(s)

Part of https://github.com/input-output-hk/catalyst-internal-docs/issues/266

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy changed the title feat(rust/signed-doc): Brand Parameters Form Template, Proposal Comment Form Template, Proposal Form Template integration tests feat(rust/signed-doc): Brand Parameters Form Template, Brand Parameters, Proposal Comment Form Template, Proposal Form Template integration tests Sep 23, 2025
@Mr-Leshiy Mr-Leshiy added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Sep 23, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 🏗 In progress in Catalyst Sep 23, 2025
@Mr-Leshiy Mr-Leshiy changed the title feat(rust/signed-doc): Brand Parameters Form Template, Brand Parameters, Proposal Comment Form Template, Proposal Form Template integration tests feat(rust/signed-doc): Brand Parameters Form Template, Brand Parameters, Proposal Comment Form Template etc. integration tests Sep 24, 2025
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review September 24, 2025 11:26
@Mr-Leshiy Mr-Leshiy moved this from 🏗 In progress to 👀 In review in Catalyst Sep 24, 2025
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Sep 24, 2025
@Mr-Leshiy Mr-Leshiy force-pushed the feat/proposal-form-template-test branch from 51a3231 to 133efa2 Compare September 24, 2025 11:48
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Test Report | ${\color{lightgreen}Pass: 520/520}$ | ${\color{red}Fail: 0/520}$ |

@Mr-Leshiy Mr-Leshiy force-pushed the feat/proposal-form-template-test branch from 7d60cb8 to e9d1f45 Compare September 24, 2025 12:57
@Mr-Leshiy Mr-Leshiy force-pushed the feat/proposal-form-template-test branch from 875526a to 1da1fa1 Compare September 24, 2025 17:22
Copy link
Contributor

@nathanbogale nathanbogale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 1cbeb58 into main Sep 25, 2025
43 of 44 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/proposal-form-template-test branch September 25, 2025 06:18
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants