Skip to content

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Oct 10, 2025

Description

Refactoring PR, moving most of the rules unit tests into their own tests.rs files.
This approach of separation a huge amount of test code, would increase the readability of the actual code

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Oct 10, 2025
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Oct 10, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Oct 10, 2025
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review October 10, 2025 04:09
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 520/520}$ | ${\color{red}Fail: 0/520}$ |

Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit de1f0fc into main Oct 10, 2025
28 of 29 checks passed
@Mr-Leshiy Mr-Leshiy deleted the chore/signed-doc-tests branch October 10, 2025 10:48
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants