Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Oct 16, 2025

Description

Fixed decoding of the collaborators metadata field and DocumentOwnershipRule validation rule with among with some cleanups and providing more tests

Description of Changes

  • Modified DocumentOwnershipRule validation logic
  • Refactored and added more tests cases for DocumentOwnershipRule
  • Fixed collaborators decoding, it should be always in URI form and contains at leas one CatalystId entry
  • Updated collaborators cddl specs.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Oct 16, 2025
@Mr-Leshiy Mr-Leshiy added draft Draft squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Oct 16, 2025
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review October 16, 2025 11:42
@Mr-Leshiy Mr-Leshiy requested review from apskhem, saibatizoku and stanislav-tkach and removed request for stanislav-tkach October 16, 2025 11:42
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review and removed draft Draft labels Oct 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Test Report | ${\color{lightgreen}Pass: 530/530}$ | ${\color{red}Fail: 0/530}$ |

@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Oct 17, 2025
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit e48c293 into main Oct 17, 2025
25 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/collaborators branch October 17, 2025 08:31
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants