Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Oct 29, 2025

Description

Using the latest CatalystId with the new admin functionality. Updates SignatureKid validation rule with the new admin definition logic.

Related Issue(s)

Closes #601

Description of Changes

  • Bumped the catalyst-types dependency for catalyst-singed-doc crate.
  • Changed the SignatureKid constructor, so if spec.admin vector is not empty, this document must been signed by admin kid.
  • Changed the logic of SignatureKid, if allowed_roles is set to empty so this document must been signed by admin kid.
  • Updated tests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Oct 29, 2025
@Mr-Leshiy Mr-Leshiy added squad: gatekeepers Catalyst App Backend, System Development & Integration Team review me PR is ready for review labels Oct 29, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 🏗 In progress in Catalyst Oct 29, 2025
@Mr-Leshiy Mr-Leshiy changed the title feat(rust/signed-doc): New CatalystId admin functionality feat(rust/signed-doc): New CatalystId admin functionality for SignatureKid validation rule Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Test Report | ${\color{lightgreen}Pass: 554/554}$ | ${\color{red}Fail: 0/554}$ |

@Mr-Leshiy Mr-Leshiy merged commit 8e1eb8f into main Oct 30, 2025
62 of 67 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/signed-doc-admin branch October 30, 2025 02:44
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Catalyst Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Admin keys verification

3 participants