Skip to content

Conversation

@apskhem
Copy link
Collaborator

@apskhem apskhem commented Nov 3, 2025

Description

  • Replaced system::time with chrono within the catalyst-signed-doc crate omitting just the provider

Related Issue(s)

Closes #611

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Nov 3, 2025
@apskhem apskhem added the review me PR is ready for review label Nov 3, 2025
@apskhem apskhem added this to Catalyst Nov 3, 2025
@apskhem apskhem added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Nov 3, 2025
@apskhem apskhem linked an issue Nov 3, 2025 that may be closed by this pull request
@apskhem apskhem moved this from New to 👀 In review in Catalyst Nov 3, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Nov 4, 2025
@apskhem apskhem moved this from 🔖 Ready to 🏗 In progress in Catalyst Nov 4, 2025
@apskhem apskhem requested a review from Mr-Leshiy November 4, 2025 09:29
@apskhem apskhem moved this from 🏗 In progress to 👀 In review in Catalyst Nov 4, 2025
Mr-Leshiy
Mr-Leshiy previously approved these changes Nov 5, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy force-pushed the fix/main-signed-doc-time-check branch from 738b3d7 to d6cdc22 Compare November 5, 2025 04:58
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Test Report | ${\color{lightgreen}Pass: 554/554}$ | ${\color{red}Fail: 0/554}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) November 5, 2025 08:10
@Mr-Leshiy Mr-Leshiy merged commit a6e629f into main Nov 5, 2025
13 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/main-signed-doc-time-check branch November 5, 2025 09:31
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Utc::now instead of SystemTime::now for catalyst-signed-doc crate

4 participants