Skip to content

feat(rust/signed-doc): CatalystSignedDocument has CIDv1 #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(rust/signed-doc): CatalystSignedDocument has CIDv1 #621

wants to merge 1 commit into from

Conversation

@saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Nov 5, 2025 •
edited
Loading

Description

Add CIDv1 for CatalystSignedDocument.

Related Issue(s)

Closes #585

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku self-assigned this Nov 5, 2025
@saibatizoku saibatizoku added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Nov 5, 2025
@saibatizoku saibatizoku moved this from New to 🏗 In progress in Catalyst Nov 5, 2025
@saibatizoku saibatizoku force-pushed the fix/doclocator-uses-cid-v1 branch from 7181765 to cbe1b93 Compare November 5, 2025 17:09
stevenj
stevenj approved these changes Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku force-pushed the fix/doclocator-uses-cid-v1 branch from cbe1b93 to 7119736 Compare November 7, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenj stevenj stevenj approved these changes

Assignees

@saibatizoku saibatizoku

Labels

squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Catalyst
Status: 🏗 In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Catalyst Signed Documents DocLocator proper definition

3 participants

@saibatizoku @stevenj